fix: lint error and unit tests#1945
Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom Apr 5, 2022
Merged
Conversation
✅ Deploy Preview for devspace-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pratikjagrut
force-pushed
the
fix.lint.unit.test
branch
4 times, most recently
from
ff4ad7a to
ad132b5
Compare
FabianKramm
requested changes
Apr 5, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@pratikjagrut thanks a lot for the PR! LGTM, but there are 2 small things you could change, please see my comments below
pratikjagrut
force-pushed
the
fix.lint.unit.test
branch
from
ad132b5 to
4c634bc
Compare
pratikjagrut
force-pushed
the
fix.lint.unit.test
branch
from
4c634bc to
d99e863
Compare
pratikjagrut
force-pushed
the
fix.lint.unit.test
branch
from
d99e863 to
2215fc4
Compare
FabianKramm
approved these changes
Apr 5, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@pratikjagrut LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind test